Comments on: Find Missing Indexes in Stored Procs with T-SQL

By: Greg

Greg — Wed, 05 Oct 2011 18:56:07 +0000

I have the same issue that MyDogJessie does.

By: Patrick

Patrick — Fri, 25 Mar 2011 15:54:16 +0000

Hi Michelle,
I found a small bug with your code, the databases with dash character in it will though error.
simple change Use ? to Use [?] and it will resolve the issue.

Roman, try it out and see if it will fix your problem too.

By: MyDoggieJessie

MyDoggieJessie — Sun, 06 Mar 2011 03:47:06 +0000

Running this out of the box (as posted, and including the Loggin procedure for your other blog) I got:

Msg 50000, Level 15, State 1, Procedure dba_LogErrorForMissingIndexes, Line 152
Violation of PRIMARY KEY constraint ‘PK_temp_missingIndexes’. Cannot insert duplicate key in object ‘dbo.#missingIndexes’. The duplicate key value is (32767, 1003234025).

By: Roman

Roman — Fri, 31 Dec 2010 11:19:33 +0000

Hi Michelle

Looks like stor proc does not work if database name has dot.
If db names is TechOnsite.HelpDesk then you will have error:

Msg 50000, Level 15, State 1, Procedure dba_logError_sp, Line 152
Database ‘TechOnsite’ does not exist. Make sure that the name is entered correctly.

By: Montrial

Montrial — Wed, 16 Jun 2010 13:49:05 +0000

Thanks again Michelle for your awesome posts. You just saved me a lot of time. Again!!

By: Ewan

Ewan — Thu, 01 Apr 2010 08:27:17 +0000

Hi Michelle

Love your blog. I read a different blog recently, and remembered your USE ? statement here. In SQL2005 SP2, the object_id function was upgraded – you can now use object_id(objid, dbid) to return the object name!

HTH

Ewan

By: Kobe Lenjou

Kobe Lenjou — Mon, 15 Mar 2010 14:09:13 +0000

I made a small change, you should change the two occurances of

EXECUTE sp_msForEachDB ‘Use ?;

EXECUTE sp_msForEachDB ‘Use [?];

for those of uw who have funky database names.

By: The Rambling DBA: Jonathan Kehayias

The Rambling DBA: Jonathan Kehayias — Mon, 27 Jul 2009 15:27:44 +0000

Digging into the SQL Plan Cache: Finding Missing Indexes…

This is one of those topics I planned to blog about a long time ago, but never actually got around to…

By: joe tigeleiro

joe tigeleiro — Tue, 19 May 2009 18:15:24 +0000

Is their a way to generate the missing index detail information into a create index statements just like SSMS does? It would be? I could find how SSMS parses the information.

By: Tom Groszko

Tom Groszko — Tue, 28 Apr 2009 20:32:26 +0000

I had not seen, at least not noticed, the missing index comment before in query plans. What other kinds of things are there in these plans that could just as easily be searched for?

Thanks